[GTK4] Fix custom drawing in GTK4#2822
Closed
jonahgraham wants to merge 1 commit intoeclipse-platform:masterfrom
Closed
[GTK4] Fix custom drawing in GTK4#2822jonahgraham wants to merge 1 commit intoeclipse-platform:masterfrom
jonahgraham wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
This involves changing the mechanism with which we do custom drawing. Previously we tried to hook into GtkWidget's snapshot, but this required messing around with the vtable of the widget to call our handler instead. This commit changes to using GtkOverlays + GtkDrawingAreas to allow custom drawing on top of the GtkWidgets. Fixes eclipse-platform#2819
Contributor
Author
|
This is draft because it is only the first step of #2819 (comment) - new commits/pushes as I get the other steps done. |
Contributor
Test Results 118 files ±0 118 suites ±0 19m 39s ⏱️ + 3m 24s Results for commit 99d94c0. ± Comparison against base commit a0d6ffc. This pull request skips 1 test. |
Member
|
#3069 fixes the issue so I propose we close this one for now. Using GtkOverlay will require far bigger changes than we can afford doing now. |
Contributor
Author
|
I am closing this for now - the caret drawing has been fixed a different way. I still have concerns about rewriting snapshot by editing vtable, but to reduce noise I close this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This involves changing the mechanism with which we do custom drawing. Previously we tried to hook into GtkWidget's snapshot, but this required messing around with the vtable of the widget to call our handler instead.
This commit changes to using GtkOverlays + GtkDrawingAreas to allow custom drawing on top of the GtkWidgets.
Fixes #2819